[OPIK-311] Update prompt #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com/comet-ml/opik into thiagohora/OPIK-309_exposing_api_contracts
…hora/OPIK-309_exposing_api_contracts
…hora/OPIK-309_exposing_api_contracts
…hora/OPIK-310_expose_get_prompts_api
…hora/OPIK-310_expose_get_prompts_api
…hora/OPIK-314_create_version_endpoint
Base automatically changed from
thiagohora/OPIK-314_create_version_endpoint
to
main
November 5, 2024 13:56
thiagohora
force-pushed
the
thiagohora/OPIK-311_update_prompt
branch
2 times, most recently
from
3b58058
to
09c3cae
Compare
thiagohora
force-pushed
the
thiagohora/OPIK-311_update_prompt
branch
from
09c3cae
to
faebd86
Compare
idoberko2
reviewed
Nov 5, 2024
|
|
||
| @Test | ||
| @DisplayName("when updating prompt name to an existing one, then return conflict") | ||
| void when__promptContainsFirstVersionTemplate__thenReturnUpdatedPrompt() { |
There was a problem hiding this comment.
Suggested change
| void when__promptContainsFirstVersionTemplate__thenReturnUpdatedPrompt() { | |
| void when__updatePromptNameToExisting__thenReturnConflict() { |
There was a problem hiding this comment.
Good catch, thank you!
idoberko2
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Update prompt
Issues
OPIK-311