[OPIK-314] Create prompt version endpoint #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com/comet-ml/opik into thiagohora/OPIK-309_exposing_api_contracts
…hora/OPIK-309_exposing_api_contracts
…hora/OPIK-309_exposing_api_contracts
…hora/OPIK-310_expose_get_prompts_api
…hora/OPIK-310_expose_get_prompts_api
…hora/OPIK-314_create_version_endpoint
thiagohora
force-pushed
the
thiagohora/OPIK-314_create_version_endpoint
branch
from
f6dc040
to
98690af
Compare
Base automatically changed from
thiagohora/OPIK-310_expose_get_prompts_api
to
main
November 5, 2024 12:23
idoberko2
approved these changes
Nov 5, 2024
| private EntityAlreadyExistsException newConflict(String alreadyExists) { | ||
| log.info(alreadyExists); | ||
| return new EntityAlreadyExistsException(new ErrorMessage(alreadyExists)); | ||
| return new EntityAlreadyExistsException(new ErrorMessage(409, alreadyExists)); |
There was a problem hiding this comment.
Suggested change
| return new EntityAlreadyExistsException(new ErrorMessage(409, alreadyExists)); | |
| return new EntityAlreadyExistsException(new ErrorMessage(HttpStatus.SC_CONFLICT, alreadyExists)); |
There was a problem hiding this comment.
I will address both comments in the following PR once I rebase it
| @@ -85,6 +88,14 @@ class PromptResourceTest { | |||
|
|
|||
| private static final WireMockUtils.WireMockRuntime wireMock; | |||
| public static final String[] IGNORED_FIELDS = {"versionCount", "latestVersion", "template"}; | |||
| public static final String TEMPLATE = """ | |||
There was a problem hiding this comment.
Any reason to introduce this duplicate and not use PromptVersionManufacturer.TEMPLATE?
There was a problem hiding this comment.
No, I probably forgot to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
OPIK-314