Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM-1576]: Log System Details from Java System Properties #55

Merged
merged 11 commits into from
Feb 18, 2022

Conversation

yaricom
Copy link
Member

@yaricom yaricom commented Feb 16, 2022

comet-java-client

  • Implemented support for logging system metrics at experiment start.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Attention: Patch coverage is 64.81481% with 38 lines in your changes missing coverage. Please review.

Project coverage is 62.70%. Comparing base (c1d4e65) to head (256b4ca).
Report is 107 commits behind head on master.

Files with missing lines Patch % Lines
.../ml/comet/experiment/impl/BaseExperimentAsync.java 59.25% 10 Missing and 1 partial ⚠️
.../java/ml/comet/experiment/impl/BaseExperiment.java 46.66% 7 Missing and 1 partial ⚠️
.../comet/experiment/impl/rest/GpuStaticInfoRest.java 0.00% 8 Missing ⚠️
...ml/comet/experiment/impl/utils/ExceptionUtils.java 55.55% 2 Missing and 2 partials ⚠️
...ml/comet/experiment/impl/OnlineExperimentImpl.java 50.00% 2 Missing ⚠️
.../experiment/impl/rest/LogAdditionalSystemInfo.java 60.00% 2 Missing ⚠️
.../experiment/impl/rest/SetSystemDetailsRequest.java 91.30% 2 Missing ⚠️
...va/ml/comet/experiment/impl/utils/SystemUtils.java 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
+ Coverage     62.54%   62.70%   +0.16%     
- Complexity      863      899      +36     
============================================
  Files           115      120       +5     
  Lines          3479     3553      +74     
  Branches        301      304       +3     
============================================
+ Hits           2176     2228      +52     
- Misses          904      924      +20     
- Partials        399      401       +2     
Flag Coverage Δ
integration 62.70% <64.81%> (+0.16%) ⬆️
unittests 62.70% <64.81%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Lothiraldan Lothiraldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaricom yaricom merged commit b818b77 into master Feb 18, 2022
@yaricom yaricom deleted the CM-1576-log-system-details branch February 18, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants