Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CM-2109]: Use logicalPath everywhere where we talk about an Artifact asset name or fileName #45

Merged
merged 2 commits into from
Jan 17, 2022
Merged

[CM-2109]: Use logicalPath everywhere where we talk about an Artifact asset name or fileName #45

merged 2 commits into from
Jan 17, 2022

Conversation

yaricom
Copy link
Member

@yaricom yaricom commented Jan 17, 2022

No description provided.

Lothiraldan
Lothiraldan approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@Lothiraldan Lothiraldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are passing locally. Failure is likely due to some DNS issues

@Lothiraldan Lothiraldan merged commit 81bca30 into master Jan 17, 2022
@Lothiraldan Lothiraldan deleted the CM-2109-logical-path-everywhere branch January 17, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@Lothiraldan Lothiraldan Lothiraldan approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaricom @Lothiraldan