[CM-1592] Support for logging of assets folder #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ConnectionUtils test cases.
…to clearly separate asynchronous logic from synchronous. Fixed related test cases
…te utility class.
…t assets uploading methods.
to support methods from amended OnlineExperiment interface.
…de-clutter OnlineExperimentImpl.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
comet-java-client/src/main/java/ml/comet/experiment/impl/OnlineExperimentBuilderImpl.java
Outdated
Show resolved
Hide resolved
…ynchronous loggers by removing Async suffix. Now them all in separate class - no need any more.
…essages bundle. Fixed JavaDocs. Added warnings' suppression.
…wing automatic experiment closing when using with try-with-resources statement.
comet-java-client/src/main/java/ml/comet/experiment/context/ExperimentContext.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/context/ExperimentContext.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/asset/Asset.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/asset/Asset.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/asset/Asset.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/asset/Asset.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/model/ExperimentAssetLink.java
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/model/ExperimentAssetLink.java
Show resolved
Hide resolved
…ing recursive = false.
…s prefixed with folder name. Fixed related test cases.
…s prefixed with folder name. Fixed related test cases.
…to indicate whether parent folder name should prefix file names within folder.
…rs step and epoch are null and return the default zero in this case. This is to avoid NullPointerException when invoking getStep()/getEpoch() or nextStep()/nextEpoch().
…ated parts of the code using it.
…pty to properly handle blank strings having only whitespaces.
…text and logCode usage
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
============================================
- Coverage 53.90% 53.05% -0.86%
- Complexity 310 396 +86
============================================
Files 55 64 +9
Lines 1395 1734 +339
Branches 114 139 +25
============================================
+ Hits 752 920 +168
- Misses 488 624 +136
- Partials 155 190 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
The example experiment output |
Nimrod007
approved these changes
Dec 1, 2021
Lothiraldan
approved these changes
Dec 2, 2021
comet-java-client/src/main/java/ml/comet/experiment/impl/utils/AssetUtils.java
Outdated
Show resolved
Hide resolved
…. Fixed related test cases to check all possible combinations of the parameters against expectations.
comet-java-client/src/main/java/ml/comet/experiment/impl/BaseExperimentAsync.java
Outdated
Show resolved
Hide resolved
comet-java-client/src/main/java/ml/comet/experiment/impl/CometApiImpl.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comet-java-client
comet-examples