Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All module remove alias and refactor code #515

Merged
merged 9 commits into from
Oct 19, 2022

Conversation

dheerajkd30
Copy link
Member

No description provided.

defer telemetry.ModuleMeasureSince(types.ModuleName, ctx.BlockTime(), telemetry.MetricKeyBeginBlocker)

_ = utils.ApplyFuncIfNoError(ctx, func(ctx sdk.Context) error {
apps, found := k.GetApps(ctx)
apps, found := assetKeeper.GetApps(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
defer telemetry.ModuleMeasureSince(types.ModuleName, ctx.BlockTime(), telemetry.MetricKeyBeginBlocker)

_ = utils.ApplyFuncIfNoError(ctx, func(ctx sdk.Context) error {
auctionMapData, auctionMappingFound := k.GetAllAuctionMappingForApp(ctx)
auctionMapData, auctionMappingFound := collectorKeeper.GetAllAuctionMappingForApp(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
if auctionMappingFound {
for _, data := range auctionMapData {
killSwitchParams, _ := k.GetKillSwitchData(ctx, data.AppId)
esmStatus, found := k.GetESMStatus(ctx, data.AppId)
killSwitchParams, _ := esmKeeper.GetKillSwitchData(ctx, data.AppId)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
killSwitchParams, _ := k.GetKillSwitchData(ctx, data.AppId)
esmStatus, found := k.GetESMStatus(ctx, data.AppId)
killSwitchParams, _ := esmKeeper.GetKillSwitchData(ctx, data.AppId)
esmStatus, found := esmKeeper.GetESMStatus(ctx, data.AppId)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@@ -47,16 +48,16 @@
// }
//}

apps, appsFound := k.GetApps(ctx)
apps, appsFound := assetKeeper.GetApps(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
Copy link
Contributor

@vishnukumavat vishnukumavat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheerajkd30 dheerajkd30 merged commit a1b9996 into feature/dev Oct 19, 2022
@dheerajkd30 dheerajkd30 deleted the auction-alias-refactor branch October 25, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants