-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All module remove alias and refactor code #515
Conversation
defer telemetry.ModuleMeasureSince(types.ModuleName, ctx.BlockTime(), telemetry.MetricKeyBeginBlocker) | ||
|
||
_ = utils.ApplyFuncIfNoError(ctx, func(ctx sdk.Context) error { | ||
apps, found := k.GetApps(ctx) | ||
apps, found := assetKeeper.GetApps(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
defer telemetry.ModuleMeasureSince(types.ModuleName, ctx.BlockTime(), telemetry.MetricKeyBeginBlocker) | ||
|
||
_ = utils.ApplyFuncIfNoError(ctx, func(ctx sdk.Context) error { | ||
auctionMapData, auctionMappingFound := k.GetAllAuctionMappingForApp(ctx) | ||
auctionMapData, auctionMappingFound := collectorKeeper.GetAllAuctionMappingForApp(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
if auctionMappingFound { | ||
for _, data := range auctionMapData { | ||
killSwitchParams, _ := k.GetKillSwitchData(ctx, data.AppId) | ||
esmStatus, found := k.GetESMStatus(ctx, data.AppId) | ||
killSwitchParams, _ := esmKeeper.GetKillSwitchData(ctx, data.AppId) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
killSwitchParams, _ := k.GetKillSwitchData(ctx, data.AppId) | ||
esmStatus, found := k.GetESMStatus(ctx, data.AppId) | ||
killSwitchParams, _ := esmKeeper.GetKillSwitchData(ctx, data.AppId) | ||
esmStatus, found := esmKeeper.GetESMStatus(ctx, data.AppId) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
@@ -47,16 +48,16 @@ | |||
// } | |||
//} | |||
|
|||
apps, appsFound := k.GetApps(ctx) | |||
apps, appsFound := assetKeeper.GetApps(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.