Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alias.go #512

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Remove alias.go #512

merged 2 commits into from
Oct 17, 2022

Conversation

vishnukumavat
Copy link
Contributor

@vishnukumavat vishnukumavat commented Oct 17, 2022

Removing keeper/alias.go from liquidity module.
This was redundant mapping for imported functions from other module.

@vishnukumavat vishnukumavat changed the title Remove aliag.go Remove alias.go Oct 17, 2022
defer telemetry.ModuleMeasureSince(types.ModuleName, ctx.BlockTime(), telemetry.MetricKeyBeginBlocker)

_ = utils.ApplyFuncIfNoError(ctx, func(ctx sdk.Context) error {
allApps, found := k.GetApps(ctx)
allApps, found := assetKeeper.GetApps(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
defer telemetry.ModuleMeasureSince(types.ModuleName, ctx.BlockTime(), telemetry.MetricKeyEndBlocker)

_ = utils.ApplyFuncIfNoError(ctx, func(ctx sdk.Context) error {
allApps, found := k.GetApps(ctx)
allApps, found := assetKeeper.GetApps(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@dheerajkd30 dheerajkd30 merged commit 4a135c5 into feature/dev Oct 17, 2022
@vishnukumavat vishnukumavat deleted the alias_ditch branch December 28, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants