Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved naming convention in AuctionParams #221

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Improved naming convention in AuctionParams #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c663981
Improved naming convention in auctionParamsRequest
karthik340 Jun 9, 2022
67e2563
Merge branch 'testdev' of https://github.com/comdex-official/comdex i…
karthik340 Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions proto/comdex/auction/v1beta1/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ message QueryParamsResponse {
}

message QueryAuctionParamRequest {
uint64 id = 1;
uint64 app_id = 1;
}

message QueryAuctionParamResponse {
Expand Down Expand Up @@ -239,6 +239,6 @@ service Query {
option (google.api.http).get = "/comdex/auction/v1beta1/protocolstats/{app_id}";
}
rpc QueryAuctionParams(QueryAuctionParamRequest) returns (QueryAuctionParamResponse) {
option (google.api.http).get = "/comdex/auction/v1beta1/auctionparams/{id}";
option (google.api.http).get = "/comdex/auction/v1beta1/auctionparams/{app_id}";
}
}
2 changes: 1 addition & 1 deletion x/auction/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ func queryAuctionParams() *cobra.Command {
res, err := queryClient.QueryAuctionParams(
context.Background(),
&types.QueryAuctionParamRequest{
Id: id,
AppId: id,
},
)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions x/auction/keeper/query_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,9 +359,9 @@ func (q *QueryServer) QueryAuctionParams(c context.Context, req *auctiontypes.Qu
ctx = sdk.UnwrapSDKContext(c)
)

item, found := q.GetAuctionParams(ctx, req.Id)
item, found := q.GetAuctionParams(ctx, req.AppId)
if !found {
return nil, status.Errorf(codes.NotFound, "Auction Params not exist for id %d", req.Id)
return nil, status.Errorf(codes.NotFound, "Auction Params not exist for id %d", req.AppId)
}

return &types.QueryAuctionParamResponse{
Expand Down
183 changes: 91 additions & 92 deletions x/auction/types/query.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading