Merge pull request #336 from comdex-official/gosec-error

resovle and ignore few lint errors
comdex-official · Jul 11, 2022 · 7f6268d · 7f6268d
2 parents e5fced7 + 3edb440
commit 7f6268d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/x/asset/client/cli/parse.go b/x/asset/client/cli/parse.go
@@ -38,7 +38,7 @@ func parseAssetMappingFlags(fs *pflag.FlagSet) (*createAddAssetMappingInputs, er
 		return nil, fmt.Errorf("must pass in add asset mapping json using the --%s flag", FlagAddAssetMappingFile)
 	}
 
-	contents, err := ioutil.ReadFile(addAssetMappingFile)
+	contents, err := ioutil.ReadFile(addAssetMappingFile) //nolint:gosec
 	if err != nil {
 		return nil, err
 	}

diff --git a/x/lend/client/cli/parse.go b/x/lend/client/cli/parse.go
@@ -75,7 +75,7 @@ func parseAddNewLendPairsFlags(fs *pflag.FlagSet) (*addNewLendPairsInputs, error
 		return nil, fmt.Errorf("must pass in a add new lend pairs json using the --%s flag", FlagNewLendPairFile)
 	}
 
-	contents, err := ioutil.ReadFile(addLendPairsParamsFile)
+	contents, err := ioutil.ReadFile(addLendPairsParamsFile) //nolint:gosec
 	if err != nil {
 		return nil, err
 	}
@@ -97,7 +97,7 @@ func parseAddPoolFlags(fs *pflag.FlagSet) (*addLendPoolInputs, error) {
 		return nil, fmt.Errorf("must pass in a add new pool json using the --%s flag", FlagAddLendPoolFile)
 	}
 
-	contents, err := ioutil.ReadFile(addPoolParamsParamsFile)
+	contents, err := ioutil.ReadFile(addPoolParamsParamsFile) //nolint:gosec
 	if err != nil {
 		return nil, err
 	}
@@ -119,7 +119,7 @@ func parseAssetRateStatsFlags(fs *pflag.FlagSet) (*addAssetRatesStatsInputs, err
 		return nil, fmt.Errorf("must pass in a add asset rates stats json using the --%s flag", FlagAddAssetRatesStatsFile)
 	}
 
-	contents, err := ioutil.ReadFile(addAssetRatesStatsFile)
+	contents, err := ioutil.ReadFile(addAssetRatesStatsFile) //nolint:gosec
 	if err != nil {
 		return nil, err
 	}

diff --git a/x/liquidity/types/msgs.go b/x/liquidity/types/msgs.go
@@ -33,7 +33,7 @@ const (
 	TypeMsgCancelOrder      = "cancel_order"
 	TypeMsgCancelAllOrders  = "cancel_all_orders"
 	TypeMsgTokensSoftLock   = "tokens_soft_lock"
-	TypeMsgTokensSoftUnlock = "tokens_soft_unlock"
+	TypeMsgTokensSoftUnlock = "tokens_soft_unlock" //nolint:gosec
 )
 
 // NewMsgCreatePair returns a new MsgCreatePair.

diff --git a/x/vault/client/testutil/helpers.go b/x/vault/client/testutil/helpers.go
@@ -44,10 +44,13 @@ func MsgCreate(
 	if err != nil {
 		return resp, err
 	}
-	var respJson map[string]interface{}
-	json.Unmarshal([]byte(resp.String()), &respJson)
-	if respJson["code"] != 0 {
-		errLog, _ := respJson["raw_log"].(string)
+	var respJSON map[string]interface{}
+	err = json.Unmarshal([]byte(resp.String()), &respJSON)
+	if err != nil {
+		return nil, err
+	}
+	if respJSON["code"] != 0 {
+		errLog, _ := respJSON["raw_log"].(string)
 		err = fmt.Errorf(errLog)
 	}
 	return resp, err