Merge pull request #221 from comdex-official/dutch_tests_1

Improved naming convention in AuctionParams
comdex-official · Jun 9, 2022 · 3c3ec0e · 3c3ec0e
2 parents f56dc48 + 67e2563
commit 3c3ec0e
Show file tree

Hide file tree

Showing 5 changed files with 105 additions and 106 deletions.
diff --git a/proto/comdex/auction/v1beta1/query.proto b/proto/comdex/auction/v1beta1/query.proto
@@ -195,7 +195,7 @@ message QueryParamsResponse {
 }
 
 message QueryAuctionParamRequest {
-  uint64 id = 1;
+  uint64 app_id = 1;
 }
 
 message QueryAuctionParamResponse {
@@ -239,6 +239,6 @@ service Query {
     option (google.api.http).get = "/comdex/auction/v1beta1/protocolstats/{app_id}";
   }
   rpc QueryAuctionParams(QueryAuctionParamRequest) returns (QueryAuctionParamResponse) {
-    option (google.api.http).get = "/comdex/auction/v1beta1/auctionparams/{id}";
+    option (google.api.http).get = "/comdex/auction/v1beta1/auctionparams/{app_id}";
   }
 }
diff --git a/x/auction/client/cli/query.go b/x/auction/client/cli/query.go
@@ -484,7 +484,7 @@ func queryAuctionParams() *cobra.Command {
 			res, err := queryClient.QueryAuctionParams(
 				context.Background(),
 				&types.QueryAuctionParamRequest{
-					Id: id,
+					AppId: id,
 				},
 			)
 			if err != nil {

diff --git a/x/auction/keeper/query_server.go b/x/auction/keeper/query_server.go
@@ -359,9 +359,9 @@ func (q *QueryServer) QueryAuctionParams(c context.Context, req *auctiontypes.Qu
 		ctx = sdk.UnwrapSDKContext(c)
 	)
 
-	item, found := q.GetAuctionParams(ctx, req.Id)
+	item, found := q.GetAuctionParams(ctx, req.AppId)
 	if !found {
-		return nil, status.Errorf(codes.NotFound, "Auction Params not exist for id %d", req.Id)
+		return nil, status.Errorf(codes.NotFound, "Auction Params not exist for id %d", req.AppId)
 	}
 
 	return &types.QueryAuctionParamResponse{

diff --git a/x/auction/types/query.pb.go b/x/auction/types/query.pb.go