Fix python test failure using virtualenv<20.0.0 #641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640 and #642 and improves tests running time from ~24min down to ~15min.
$TRAVIS_PYTHON_VERSION
is unset (see Python tests are not run on all versions py27, py36, py37 #642). It looks like other projects on Github are using Travis stages to install the correct python version in each VM that is compatible to a specific tox environment.One thing to note, unfortunately, due to some python tests relying on these jars: https://github.com/combust/mleap/blob/master/mleap-spark-extension/build.sbt#L9
I am forced to run
sbt +compile
before python tests in all stages (running in different VMs) and this makes them all slower because they are all compiling the entire project.@talalryz @lydian @voganrc for review