Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create interface for Services and replace static methods with instance methods #110

Closed
massifben opened this issue Jun 17, 2022 · 0 comments · Fixed by #318 or #320
Closed

Create interface for Services and replace static methods with instance methods #110

massifben opened this issue Jun 17, 2022 · 0 comments · Fixed by #318 or #320
Assignees
@massifben
Labels
enhancement New feature or request

Comments

@massifben
Copy link
Contributor

SclService and SclAutomationService offer static methods.
The suggestion is to hide the implementation behind an interface and to use instance methods instead :

  • it allows client apps to mock the services when testing
  • it allows different implementations for these services
  • it better integrates with dependency injection frameworks
@massifben massifben added the enhancement New feature or request label Jun 17, 2022
@massifben massifben self-assigned this Jun 17, 2022
@AliouDIAITE AliouDIAITE mentioned this issue Dec 29, 2022
Merged
samirromdhani added a commit that referenced this issue Aug 21, 2023
@samirromdhani
[WIP] Create interface for Services and replace static methods with i…
82fc7ca 
…nstance methods closes #110

Signed-off-by: Samir Romdhani <[email protected]>
@samirromdhani samirromdhani mentioned this issue Aug 21, 2023
Merged
@samirromdhani samirromdhani linked a pull request Aug 21, 2023 that will close this issue
Create interface for Services and replace static methods with instance methods closes #110 #318
Merged
samirromdhani added a commit that referenced this issue Aug 22, 2023
@samirromdhani
[WIP] Create interface for Services and replace static methods with i…
0cc11f0 
…nstance methods closes #110

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 22, 2023
@samirromdhani
[WIP] Create interface for Services and replace static methods with i…
e38130a 
…nstance methods closes #110

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
refactor(#110): Create interface for Services and replace static meth…
520aca6 
…ods with instance methods

closes #110

BREAKING CHANGE: 💥 in sct-commons:
  The services which provide static methods are moved from scl to service package.
  Now  those services implements interfaces, no static methods.
  Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package.

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
refactor(#110): Create interface for Services and replace static meth…
be9ba23 
…ods with instance methods

closes #110

BREAKING CHANGE: 💥 in sct-commons:
  The services which provide static methods are moved from scl to service package.
  Now  those services implements interfaces, no static methods.
  Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package.

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
refactor(#110): give PrivateService the new name PrivateUtils and cha…
7aa0c03 
…nge the package from scl to util.

Changing the name of PrivateService to PrivateUtils and move it from scl to util package , closes #110

BREAKING CHANGE: 💥 in sct-commons:
    The services which provide static methods are moved from scl to service package.
    Now  those services implements interfaces, no static methods.
    Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package.

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
refactor(#110): give PrivateService the new name PrivateUtils and cha…
2934c31 
…nge the package from scl to util.

Changing the name of PrivateService to PrivateUtils and move it from scl to util package , closes #110

BREAKING CHANGE: 💥 in sct-commons:
    The services which provide static methods are moved from scl to service package.
    Now  those services implements interfaces, no static methods.
    ℹ️ Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package.

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
refactor(#110): give PrivateService the new name PrivateUtils and cha…
7ae1629 
…nge the package from scl to util.

Changing the name of PrivateService to PrivateUtils and move it from scl to util package , closes #110

BREAKING CHANGE: 💥 in sct-commons:
    The services which provide static methods are moved from scl to service package.
    Now  those services implements interfaces, no static methods.
    ℹ️ Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package.

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
refactor(#110): update SclAutomationService
ce9ddad 
closes #110

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
docs(#110): update demo project and quickstart page
9676fc9 
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
docs(#110): update demo project and quickstart page
6cfc470 
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 23, 2023
@samirromdhani
docs(#110): update demo project and quickstart page
16963f5 
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 25, 2023
@samirromdhani
refactor(#110): check review part1
6e37f28 
use @requiredargsconstructor, instead of @NoArgsConstructor.
use Camel case for PrivateLinkedToStds

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 25, 2023
@samirromdhani
refactor(#110): check review part2 [use mockito properly]
6169a65 
Remove unused test package.
Use latest version of mockito.
Fix related to version 5.4.0

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 25, 2023
@samirromdhani
refactor(#110): check review part2 [use mockito properly]
580a98a 
Remove unused test package.
Use latest version of mockito.
Fix related to version 5.4.0

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 25, 2023
@samirromdhani
refactor(#110): check review part2 [use mockito properly]
f155f84 
Remove unused test package.
Use latest version of mockito.
Fix related to version 5.4.0

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 25, 2023
@samirromdhani
refactor(#110): check review part2 [use mockito properly]
e042b95 
Remove unused test package.
Use latest version of mockito.
Fix related to version 5.4.0

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 25, 2023
@samirromdhani
refactor(#110): check review part2 [use mockito properly]
ccc6724 
Remove unused test package.
Use latest version of mockito.
Fix related to version 5.4.0

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 25, 2023
@samirromdhani
refactor(#110): check review part3 [naming] remove prefix 'I' and add…
3b85f2d 
… suffix 'Editor'

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 28, 2023
@samirromdhani
refactor(#110): review part3 [naming] remove prefix 'I' and add suffi…
79fbff9 
…x 'Editor'

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 28, 2023
@samirromdhani
refactor(#110): review part3 [naming] remove prefix 'I' and add suffi…
3786d2e 
…x 'Editor'

The interfaces are moved from scl to api package.

add package doc

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 28, 2023
@samirromdhani
refactor(#110): review part4 [seperate SclService features ]
916e96a 
SclEditor (interface) spec are reduced by adding ReadOnly and Write One

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 28, 2023
@samirromdhani
refactor(#110): review part4 [seperate SclService features ]
343295f 
SclEditor (interface) spec are reduced by adding ReadOnly and Write One

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 28, 2023
@samirromdhani
refactor(#110): sonar review
9fe0f18 
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 29, 2023
@samirromdhani
docs(#110): update demo project and quickstart page
4b7031b 
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 29, 2023
@samirromdhani
docs(#110): update demo project and quickstart page
5b50ef9 
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 29, 2023
@samirromdhani
refactor(#110): sonar review
cef23b3 
Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 29, 2023
@samirromdhani
docs(#110): update demo project and quickstart page
1cc1c6a 
Signed-off-by: Samir Romdhani <[email protected]>
@samirromdhani samirromdhani linked a pull request Aug 29, 2023 that will close this issue
Docs/update demo project and quickstart page #320
Merged
samirromdhani added a commit that referenced this issue Aug 30, 2023
@samirromdhani
refactor(#110): Create interface for Services and replace static meth…
ef9d944 
…ods with instance methods

closes #110

BREAKING CHANGE: 💥 in sct-commons:
  The services which provide static methods are moved from scl to service package.
  Now  those services implements interfaces, no static methods.
  Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package.

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): give PrivateService the new name PrivateUtils and change the package from scl to util.

Changing the name of PrivateService to PrivateUtils and move it from scl to util package , closes #110

BREAKING CHANGE: 💥 in sct-commons:
    The services which provide static methods are moved from scl to service package.
    Now  those services implements interfaces, no static methods.
    ℹ️ Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package.

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): update SclAutomationService

closes #110

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): check review part1

use @requiredargsconstructor, instead of @NoArgsConstructor.
use Camel case for PrivateLinkedToStds

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): check review part2 [use mockito properly]

Remove unused test package.
Use latest version of mockito.
Fix related to version 5.4.0

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): review part3 [naming] remove prefix 'I' and add suffix 'Editor'

The interfaces are moved from scl to api package.

add package doc

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): review part4 [seperate SclService features ]

SclEditor (interface) spec are reduced by adding ReadOnly and Write One

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): sonar review

Signed-off-by: Samir Romdhani <[email protected]>

docs(#110): update demo project and quickstart page

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 30, 2023
@samirromdhani
refactor(#110): Create interface for Services and replace static meth…
c13fce6 
…ods with instance methods

closes #110

BREAKING CHANGE: 💥 in sct-commons:
  The services which provide static methods are moved from scl to commons package.
  Now  those services implements interfaces, no static methods.
  Expect for PrivateService which is an UtilityClass is renamed to PrivateUtils and moved from scl to util package.

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): give PrivateService the new name PrivateUtils and change the package from scl to util.

Changing the name of PrivateService to PrivateUtils and move it from scl to util package , closes #110

refactor(#110): update SclAutomationService

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): check review part1

use @requiredargsconstructor, instead of @NoArgsConstructor.
use Camel case for PrivateLinkedToStds

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): check review part2 [use mockito properly]

Remove unused test package.
Use latest version of mockito.
Fix related to version 5.4.0

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): review part3 [naming] remove prefix 'I' and add suffix 'Editor'

The interfaces are moved from scl to api package.

add package doc

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): review part4 [seperate SclService features ]

SclEditor (interface) spec are reduced by adding ReadOnly and Write One

Signed-off-by: Samir Romdhani <[email protected]>

refactor(#110): sonar review

Signed-off-by: Samir Romdhani <[email protected]>

docs(#110): update demo project and quickstart page

Signed-off-by: Samir Romdhani <[email protected]>
samirromdhani added a commit that referenced this issue Aug 30, 2023
@samirromdhani
Merge pull request #318 from com-pas/refactor/110-create-interface-fo…
4c89e11 
…r-services-and-replace-static-methods-with-instance-methods

Create interface for Services and replace static methods with instance methods closes #110
@samirromdhani samirromdhani mentioned this issue Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@massifben massifben

Labels
enhancement New feature or request
Projects
CoMPAS SCT Board
Status: Done
Milestone
No milestone
1 participant
@massifben