Migrating to Quarkus 3.0 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
force-pushed
the
upgradeToQuarkus3.0
branch
3 times, most recently
from
c6d9481
to
09f1706
Compare
apupier
changed the title
|
Thanks for your contribution; Suggestion: Test the performance of Jaxb. Should I increment the versions in this PR or do it in a separate PR? A seperate pull-request will be fine! |
|
Quarkus 3.0.2 has been released. Will need to update the PR |
This was referenced May 9, 2023
apupier
force-pushed
the
upgradeToQuarkus3.0
branch
2 times, most recently
from
08f24cb
to
c573615
Compare
|
compared to previous version of the PR:
|
This was referenced May 26, 2023
apupier
force-pushed
the
upgradeToQuarkus3.0
branch
from
c573615
to
e27e8a4
Compare
the main change is migrating from JavaEE to JakartaEE. - update Quarkus bom from io.quarkus:quarkus-universe-bom to io.quarkus.platform:quarkus-bom as it was deprecated since Quarkus 2.1 https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.1#quarkus-universe-bom-is-deprecated (and it is required to use the Quarkus migration tool) - launched quarkus `quarkus update --stream=3.0` as mentioned in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#automatic-update-tool which dealt with a fair part of the migration. Then it remained few little tasks. - Updated one package-info annotation - Updated from jakarta.websocket:jakarta.websocket-api to io.quarkus:quarkus-websockets (another alternatives might be to add jakarta.websocket:jakarta.websocket-client-api) - Updated Jaxb generation. Moving from org.jvnet.jaxb2.maven2:maven-jaxb2-plugin to com.helger.maven:jaxb40-maven-plugin. Jaxb 3+ is supporting Jakarta. using a fork which has implemented the support of Jacxb4. The initial repository is not very active despite issue raised and a PR is proposed: see highsource/jaxb-tools#253 - updated xjb files: - namespace from `http://java.sun.com/xml/ns/jaxb` to `https://jakarta.ee/xml/ns/jaxb` - version from 1.2 to 3.0 (which is mandatory in accordance to the namespace) - Remove com.sun.xml.bind:jaxb-impl no more needed dependency Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
upgradeToQuarkus3.0
branch
from
e27e8a4
to
141d41c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
pascalwilbrink
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main change is migrating from JavaEE to JakartaEE.
io.quarkus:quarkus-universe-bomtoio.quarkus.platform:quarkus-bomas it was deprecated since Quarkus 2.1https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.1#quarkus-universe-bom-is-deprecated (and it is required to use the Quarkus migration tool)
quarkus update --stream=3.0as mentioned in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#automatic-update-tool which dealt with a fair part of the migration. Then it remained few little tasks.jakarta.websocket:jakarta.websocket-apitoio.quarkus:quarkus-websockets(another alternatives might be to add jakarta.websocket:jakarta.websocket-client-api)org.jvnet.jaxb2.maven2:maven-jaxb2-plugintocom.helger.maven:jaxb40-maven-plugin. Jaxb 3+ is supporting Jakarta. Using a fork which has implemented the support of Jacxb4. The initial repository is not very active despite issue raised and a PR is proposed: see Generate classes with Jakarta namespace highsource/jaxb-tools#253it remains some javax packages. they are javax.xml. i tis still part of the JDK so no need of migration
I guess it is a change that requires a major version upgrades.
Should I increment the versions in this PR or do it in a separate PR?
Also, i think it is impacting almost all other com-pas projects;maybe better to prepare PR for all other repositories before merging this one.