Fix Bool pattern matching to be exhaustive #461
Conversation
| upack.Bool(true) match { | ||
| case upack.Bool(value) => | ||
| } |
There was a problem hiding this comment.
This test assumes we're using -Xfatal-warnings, right? If not, I don't see how this test is supposed to detect non-exhaustiveness.
There was a problem hiding this comment.
Yes, exactly. I added it in the previous PR exactly for this test. I don't know if there is a better way to test this.
There was a problem hiding this comment.
That means, if the settings get changed later, we have no indicator that this test becomes insufficient. The bare minimum is a comment in code or in the test name. A bit better would be to detect the flags (e.g. by generating some build info code). I know utest has compileError; maybe it also fails a warning under -Xfatal-warnings, in which case we could guard some code that emits a warning with compileError to detect when this setting gets removed in the future?
|
Gonna merge this to get it in for the 3.0.0 release |
Fixes #456