Fix property handling and add tests and docs #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
pushed a commit
to lefou/mill
that referenced
this pull request
Oct 21, 2024
Fixes com-lihaoyi#3789. We just accidentally flipped the conditional and didn't have any tests that verify this behavior, so I added some example tests that also serve to explain the feature in the docs
|
@lefou yeah the test cases failed without the included fix |
lefou
added a commit
that referenced
this pull request
Oct 22, 2024
Fixes #3789. We just accidentally flipped the conditional and didn't have any tests that verify this behavior, so I added some example tests that also serve to explain the feature in the docs. Backport of pull request: #3791 Pull request: #3795 --------- Co-authored-by: Li Haoyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3789. We just accidentally flipped the conditional and didn't have any tests that verify this behavior, so I added some example tests that also serve to explain the feature in the docs