Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.mill files compiled by Scala 3 #3369

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

build.mill files compiled by Scala 3 #3369

wants to merge 23 commits into from

Commits on Oct 14, 2024

  1. FIX METALS - mill-build/build.sc -> mill-build/build.mill

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e3bfb3a View commit details
    Browse the repository at this point in the history

  2. Part 1 - fix compilation errors and stub macros 

    - use Scala 3.5.0
- add Scala 3 dialect to scalafmt.conf
- synthesize Mirrors from macro
- remove some warnings
- run scalafmt on previous code
- use scala 3 version of scalatags in test
  Note: scalatags brings in scala 2 version of sourcecode transitively,
  which then fails to summon sourcecode.Enclosing.
- re-enable jmh, bsp and testkit modules in integration tests
- fix giter8 module resolution with scala 3
- fix compilation of scalalib tests - derive ReadWriter for PomSettings
- fix compilation of scalajslib tests
- fix compilation of scalanativelib tests
- move things-outside-top-level-module to integration.feature
- resolve scala-library when mill scala version is 3.x
- add given imports
    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ee74dd7 View commit details
    Browse the repository at this point in the history

  3. Part 2 - reimplement discover macro 

    - add import mill.given
- fix summon of Discover in CodeGen
    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c2474b5 View commit details
    Browse the repository at this point in the history

  4. Part 3 - move implementation of Caller.generate to Module

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    53745d1 View commit details
    Browse the repository at this point in the history

  5. Part 4 - reimplement Applicative and Target macros

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    05111a2 View commit details
    Browse the repository at this point in the history

  6. Part 6 - implement EnclosingClass, pass specific integration tests

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    699adc1 View commit details
    Browse the repository at this point in the history

  7. Part 7 - implement Cross.Factory macro (TODO split shims out) 

    - fix scanning of Cross modules in Discover macro
- improvement: check factory value matches crossValueN
    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    122a988 View commit details
    Browse the repository at this point in the history

  8. Part 8 - adjust Zinc reporter instead of linenumbers plugin 

    enhancement to zinc reporter and avoid mangling ansi escapes
    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9d45ff0 View commit details
    Browse the repository at this point in the history

  9. Part 9 - fix CodeGen integration tests for Scala 3 

    - update com-lihaoyi/sourcecode to use new macro implementation
- fix callgraph 4-actors test: account for private[this] inferrence
- fix - callgraph 8-linked-list-scala test: account for new override semantics
- fix 5-parser codesig test to account for new expansion
- use custom SAM type in lambda tests for scala (specialisation dropped in scala 3)
- tweak CodeSig ignoreCall logic to account for Scala 3 lambdas
- update some dependencies so invalidation tests actually run
- fix indentation in codesig tests
    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    508f42c View commit details
    Browse the repository at this point in the history

  10. Part 10 - fix GenIdea 

    - In Scala 3 an implicitly inserted else branch will not be implicitly converted
  to the type of the then branch, so use explicit else branch with NodeSeq.Empty
    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    448c915 View commit details
    Browse the repository at this point in the history

  11. Part 12 - rework contrib.scoverage.api to be java based.

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d63b87d View commit details
    Browse the repository at this point in the history

  12. TEMP: skip integration.feature[plugin-classpath].local.test

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    be85915 View commit details
    Browse the repository at this point in the history

  13. Part 13 - fix contrib.playlib resolution of twirl and router worker

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a9fdb2e View commit details
    Browse the repository at this point in the history

  14. Part 14 - fix contrib.proguard default options to filter scala.AnyKind

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d74e56b View commit details
    Browse the repository at this point in the history

  15. TEMP: skip scalafix ExplicitResultType for scala 3, fix binary to 2.13

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    32c7fad View commit details
    Browse the repository at this point in the history

  16. Fix resolution of Mima previous artifacts

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    36fb83d View commit details
    Browse the repository at this point in the history

  17. TEMP: skip mima checking because scala 3 introduces too many errors

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    71c292b View commit details
    Browse the repository at this point in the history

  18. Add .zed to .gitignore

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d583cdb View commit details
    Browse the repository at this point in the history

  19. Part NN - Implement Scala 3 syntax support 

    - create and load scala compiler worker from MillMain
- splitScript (mill scripts are a compilation unit where top stats are a template stat sequence)
- cached initCtx
- tested concurrent parsing
- bin-pack comma separated import clauses into one
- extract ImportTree from import code snippets
- extract ObjectData from object code snippets
- patch end marker of wrapper object
- splice millDiscover into wrapper object after last statement
- add passing scala-3-syntax test
- account for code splice offset in ZincWorkerImpl reporter
    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b228669 View commit details
    Browse the repository at this point in the history

  20. generate patch diff for bootstrap 

    new bootstrap patch

remake patch

regenerate patch

correct bootstrap patch

new rebootstrap patch

regen bootstrap

regenerate bootstrap patch again

regenerate patch
    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    62a5815 View commit details
    Browse the repository at this point in the history

  21. Adjust DocAnnotationsTests: elide line number and extra interfaces

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c2c1d08 View commit details
    Browse the repository at this point in the history

  22. fix integration.feature[bsp-server] tests

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c5a54b7 View commit details
    Browse the repository at this point in the history

  23. correct post-splice shift ZincWorkerImpl's reporter

    @bishabosha
    bishabosha committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e13550b View commit details
    Browse the repository at this point in the history