Fix #2946: Avoid evaluating T.input
s twice
#2952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2946
In
evaluateNamed
, after evaluatingTask
s we are matching forImputImpl[_]
instances to construct aWatchable
.A
Watchable
instance contains ahashCode
for the current result and a callback to evaluate it again and get the next result.Instead of using the current result which was contained in
TaskResult
, we were already calling therecalc
callback, which executes again theT.input
s and performs their side effects twice.Now we are returning the hashCode for the already computed result, so we don't execute the
recalc
callback right away.Pull Request: #2952