Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always resolve compiler bridge in prepareOffline #2791

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Always resolve compiler bridge in prepareOffline #2791

merged 1 commit into from
Sep 28, 2023

Conversation

lefou
Copy link
Member

@lefou lefou commented Sep 28, 2023

This PR changed the behavior of ScalaModule.prepareOffline. Before, it only fetched the compiler bridge when the --all flag was given. But the compiler bridge is always needed to compile, hence I removed the need for the --all flag.

Pull request: #2791

@lefou lefou merged commit a614c89 into main Sep 28, 2023
37 checks passed
@lefou lefou deleted the fix-2632 branch September 28, 2023 13:04
@lefou lefou added this to the 0.11.5 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepareOffline does not install the relevant compiler-bridge?
1 participant