Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some hardcoded scala versions #2768

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Fix some hardcoded scala versions #2768

merged 4 commits into from
Sep 20, 2023

Conversation

lefou
Copy link
Member

@lefou lefou commented Sep 19, 2023

The Scala version used in MillBuildBootstrapModule to compile the build.sc was hardcoded to 2.13.10. Instead, we want to always use the same version we used to build that Mill version.

As an side effect, Mill is now compatible with new Java 21, due to the use of a newer Scala version.

@lefou lefou marked this pull request as ready for review September 19, 2023 21:40
@lefou
Copy link
Member Author

lefou commented Sep 20, 2023

@lefou lefou linked an issue Sep 20, 2023 that may be closed by this pull request
@lefou lefou merged commit 83d8be1 into main Sep 20, 2023
37 checks passed
@lefou lefou deleted the fix-hardcoded branch September 20, 2023 11:18
@lefou lefou added this to the 0.11.5 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better scalaVersion handling in MillBuildRootModule
1 participant