Fix the scala-library dependency for (generic) platform modules #2739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Scala 3 modules, that also define a platform, the scala library is not correctly resolved.
The current implementation exists merely as a convenience for JS and Native modules.
ScalaNativeModule
already handles a correct scala library by overridingscalaLibraryIvyDeps
. This pull request overrides the same inScalaJSModule
and removed the faulty platfrom dependency fromScalaModule
.E.g. imagine, someone tries to build a Mill plugin with Scala 3 (which is currently not supported) and sets the platform to
_mill0.11
, then you would run into the following issue: