Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow special characters in main method names and argument names #13

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Allow special characters in main method names and argument names #13

merged 2 commits into from
Dec 3, 2021

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Dec 3, 2021 •
edited
Loading

Fixes #8

We need to use .decoded to ensure we get the non-mangled version. Added a unit test to verify the fix

Review by @lolgab

@lihaoyi lihaoyi requested a review from lolgab December 3, 2021 00:39
lolgab
lolgab approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@lolgab lolgab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lihaoyi lihaoyi merged commit ff8500e into master Dec 3, 2021
@lihaoyi lihaoyi mentioned this pull request Dec 7, 2021
Closed
@lolgab lolgab deleted the dashed-names branch February 27, 2022 16:48
@lefou lefou added this to the 0.2.2 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolgab lolgab lolgab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.

support kebab-case options
3 participants
@lihaoyi @lolgab @lefou