-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@nowarn annotation does not suppress any warnings (200USD Bounty) #285
Comments
Same here. Reproduces both with Scala 2.13.10 and 3.2.2 |
presumably this started with #281 |
well, presumably just a warning, that you have yourself promoted to an error with if someone is looking for a workaround, I think " |
I tried to add |
I wasn't able to find an other way than disabling useless nowarn warning with |
So, one can selectively silent the problematic warning on specific file but keep them for other files with combined filter. Will silent the This is good enought for the time being for me. |
Somehow I'm not able to reproduce this inside my test suite. Would appreciate any help if someone wants to look into this inside the Fastparse repo and come up with a repro |
@lihaoyi I don't know if this is related, but here's the error I got for 2.13.1 (and only that version): https://github.com/scalameta/scalameta/actions/runs/5503580335/jobs/10028930479?pr=3246 |
Maybe it's specific to particular Scala versions? @soufianexmx @limansky @fanf what Scala versions are you guys seeing this in? |
2.13.10 for me I think. |
We first saw it in 2.13.10, and I checked it's still the case in 2.13.11 |
@lihaoyi I've tried with both 2.13.10 and 2.13.11. It looks like you have to have |
Ah I think it must be the |
@lihaoyi |
I'm using Fastparse too in a Java project, I would like to give this a try, this weekend. |
@He-Pin please go ahead! |
Motivation: refs: #285 with reading: https://www.scala-lang.org/2021/01/12/configuring-and-suppressing-warnings.html Modification: 1. I updated some depenecies,both scala and etc 2. because of com-lihaoyi/mill#3167, I have to comments out the native modules locally 3. add `-Xlint:unused` to reproduce the problem 4. updated some tests when `3` is enabled. 5. remove 2.11 related code 6. as Scala 2.12.x now supports the nowarn , so I changed the code to use the `@nowarn` annotation directly. 7. the root cause is the annotation in `WhiteSpace` macro Result: I think the issue is fixed now, and as I'm using Fastparse within a Java project, so I was not knowing this issue. All tests passed locally.
Should be fixed by #310 |
👏 |
Using Scala 2.13, after upgrading to version 3.0.1, for a code like:
we get compilation error:
Haoyi: To incentivize contribution, I'm putting a 200USD bounty on resolving this ticket. This is payable via bank transfer, and at my discretion in case of ambiguity. The acceptance criteria is a PR fixing this issue and updates to our test infrastructure to validate the fix
The text was updated successfully, but these errors were encountered: