-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cask returns 405 for an undefined route that uses a method not used by other routes. #51
Comments
megri
added a commit
to megri/cask
that referenced
this issue
May 18, 2021
Fixes com-lihaoyi#51. Prior to this commit, `prepareRouteTries` created a mapping from method-name to DispatchTrie (Map[String, DispatchTrie[…]]). This commit instead creates a DispatchTrie[Map[String, …]], basically an inversion of the previous result. The updated tests in minimalApplication and minimalApplication2 have been updated to cover the differences.
megri
added a commit
to megri/cask
that referenced
this issue
May 18, 2021
Fixes com-lihaoyi#51. Prior to this commit, `prepareRouteTries` created a mapping from method-name to DispatchTrie (Map[String, DispatchTrie[…]]). This commit instead creates a DispatchTrie[Map[String, …]], basically an inversion of the previous result. The updated tests in minimalApplication and minimalApplication2 have been updated to cover the differences.
megri
added a commit
to megri/cask
that referenced
this issue
May 18, 2021
Fixes com-lihaoyi#51. Prior to this commit, `prepareRouteTries` created a mapping from method-name to DispatchTrie (Map[String, DispatchTrie[…]]). This commit instead creates a DispatchTrie[Map[String, …]], basically an inversion of the previous result. The updated tests in minimalApplication and minimalApplication2 have been updated to cover the differences.
megri
added a commit
to megri/cask
that referenced
this issue
May 18, 2021
Fixes com-lihaoyi#51. Prior to this commit, `prepareRouteTries` created a mapping from method-name to DispatchTrie (Map[String, DispatchTrie[…]]). This commit instead creates a DispatchTrie[Map[String, …]], basically an inversion of the previous result. The updated tests in minimalApplication and minimalApplication2 have been updated to cover the differences.
megri
added a commit
to megri/cask
that referenced
this issue
May 18, 2021
Fixes com-lihaoyi#51. Prior to this commit, `prepareRouteTries` created a mapping from method-name to DispatchTrie (Map[String, DispatchTrie[…]]). This commit instead creates a DispatchTrie[Map[String, …]], basically an inversion of the previous result. The updated tests in minimalApplication and minimalApplication2 have been updated to cover the differences.
megri
added a commit
to megri/cask
that referenced
this issue
May 18, 2021
Fixes com-lihaoyi#51. Prior to this commit, `prepareRouteTries` created a mapping from method-name to DispatchTrie (Map[String, DispatchTrie[…]]). This commit instead creates a DispatchTrie[Map[String, …]], basically an inversion of the previous result. The updated tests in minimalApplication and minimalApplication2 have been updated to cover the differences.
lihaoyi
pushed a commit
that referenced
this issue
Nov 15, 2021
…5 responses. (#52) Prevent cask from responding with 405 for an undefined route. Fixes #51. Prior to this commit, `prepareRouteTries` created a mapping from method-name to DispatchTrie (Map[String, DispatchTrie[…]]). This commit instead creates a DispatchTrie[Map[String, …]], basically an inversion of the previous result. The updated tests in minimalApplication and minimalApplication2 have been updated to cover the differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As tested with Scala 3 and cask 0.7.11
Server definition
Example queries with responses
Expected outcomes
Request -> response 1 is expected
Request -> response 2 should be 405 but is 404
Request -> response 3 should be 404 but is 405
The text was updated successfully, but these errors were encountered: