Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring the plugin to only emit warnings #24

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

oyvindberg
Copy link
Contributor

I wanted this when retrofitting a project with acyclic after it was written so it can be done a bit more piece by piece. WDYT?

@akashSri92
Copy link

Nice.. I have a requirement which needs just this.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this PR and it looks good to me. Could you please rebase it on current master to resolve the conflicts. Se also my comments below.

build.sbt Outdated Show resolved Hide resolved
@lefou lefou requested a review from lihaoyi January 12, 2022 21:48
@lefou
Copy link
Member

lefou commented Jan 12, 2022

I merged current master branch and resolved my own review comments. @lihaoyi WDYT?

@oyvindberg
Copy link
Contributor Author

5 years, let's go! :)

@lihaoyi
Copy link
Member

lihaoyi commented Jan 13, 2022

Looks good to me

@lefou lefou merged commit 4b70a2e into com-lihaoyi:master Jan 13, 2022
@lefou
Copy link
Member

lefou commented Jan 13, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants