Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl should fail when it can't succeed #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshbuddy
Copy link

Noticed a problem where bitbucket isn't returning the correct file, this should fix it.

@mennomenno
Copy link

I'm piggybacking on this issue to add some info for those running into somewhat surprising error messages when curl fails. If you're running into this with phantomjs-gem 1.9.7.0:

Phantomjs does not appear to be installed in /home/whatever/.phantomjs/1.9.7/x86_64-linux/bin/phantomjs, installing!
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 14134  100 14134    0     0  15757      0 --:--:-- --:--:-- --:--:-- 15756
bunzip2: phantomjs-1.9.7-linux-x86_64.tar.bz2 is not a bzip2 file.
tar: phantomjs-1.9.7-linux-x86_64.tar: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now

It could well be because the download urls are outdated and the curl command happily puts a 403 page in the tar.bz2 file (which bunzip2 isn't too happy about of course). Update to 1.9.7.1 and you get working downloads again.

+1 for making this curl call more robust.

@jaurand
Copy link

jaurand commented Dec 22, 2014

I tried putting 1.9.7.1 in our gemfile and I got this:

Fetching gem metadata from https://rubygems.org/........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
You have requested:
phantomjs >= 1.9.7.1

The bundle currently has phantomjs locked at 1.9.7.0.
Try running bundle update phantomjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants