Allow system to have a higher version of PhantomJS installed. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in the same boat as @Aevin1387. This would be very beneficial to have the PhantomJS gem use 1.9.6. |
| @@ -32,7 +32,8 @@ def system_phantomjs_version | |||
| end | |||
|
|
|||
| def system_phantomjs_installed? | |||
| system_phantomjs_version == Phantomjs.version | |||
| version = system_phantomjs_version | |||
| version ? version >= Phantomjs.version : false | |||
There was a problem hiding this comment.
This version test fails for comparisons such as '1.10.0' > '1.9.6'.
I have partially finished branch which adds support for specifying the acceptable version range, and the default setting would have the effect you're going for here. I'll take a look at it again this weekend.
|
👍 |
|
I very much appreciate this PR, but I'm going to close it and refer everyone to PR #31. That PR does this by default and makes it all configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have 1.9.6 installed on my machine, but due to the version check to see if PhantomJS is installed, this installs 1.9.2 on my machine. Since this gem is forced on me from the jasmine-rails gem, I have created a patch.