Update types.ts Refactor the openModal method type definition #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that params are required, so the function cannot be called without them.
CharlesMangwa
requested changes
Aug 30, 2024
There was a problem hiding this comment.
hey @ramizqazi & thx for submitting this pr!
unfortunately, i cannot merge it as is for 2 reasons:
- not all
openModaltypes were updated (see 1, 2 & 3) - most importantly: your proposal unfortunately does not work when a modal doesn't expect any param. one would be forced to provide a 2nd argument anyway:
let me know if i can help you come up with a fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that params are required, so the function cannot be called without them as suggested in this issue #135