[oklch] Rename Oklch → OKLCh
#608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same name is already used in the test suite, so I decided to go with it.
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LeaVerou
approved these changes
Nov 13, 2024
|
Thx! |
|
The name was changed from |
|
I think it was changed in #300 to reflect how it is named in CSS. So I am surprised to see this get renamed here as well. With that said, the creator mentions it as OkLCh, not OKLCh (see here). It is quite common to mention LCh in this manner. I think, because this was meant to match how CSS refers to the space, it should not have been reverted as how the author mentioned it had already been taken into consideration IIRC when the change was originally made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same name is already used in the test suite, so I decided to go with it.