[ci] Update lint rules for PR's #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MysteryBlokHed
changed the title
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MysteryBlokHed
changed the title
For some reason, I cannot get the eslint checks to fail locally and produce the same errors as the CI did. I'm going to temporarily commit this to get the CI to run against it and see whether it passes.
This reverts commit 02cc49e. CI passed; I'll move this change to a separate PR.
jgerigmeyer
approved these changes
Feb 19, 2024
I don't blame you—Honestly, I feel like some of the conditions to run CI are pretty poorly documented on GitHub's pages. I found a list of valid |
jgerigmeyer
added a commit
that referenced
this pull request
Feb 19, 2024
ardov
pushed a commit
to ardov/color.js
that referenced
this pull request
Feb 27, 2024
* [ci] Run lint rules on opened *and* reopened PRs * [types] Temporary commit to test CI For some reason, I cannot get the eslint checks to fail locally and produce the same errors as the CI did. I'm going to temporarily commit this to get the CI to run against it and see whether it passes. * Revert "[types] Temporary commit to test CI" This reverts commit 02cc49e. CI passed; I'll move this change to a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR I just merged (#436) passed all the CI on the pull request page, but failed once it was merged into main. This is because the lint CI didn't actually run on the PR.
This change makes the CI rerun when a PR is opened, reopened, and when commits are pushed.