Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types] Fix clone signature #289

Closed
wants to merge 1 commit into from
Closed

[types] Fix clone signature #289

wants to merge 1 commit into from

Conversation

MysteryBlokHed
Copy link
Member

@MysteryBlokHed MysteryBlokHed commented Feb 25, 2023 •
edited
Loading

Closes #288

Fixes the types for the clone function. The function only returns a few keys from the passed object, not a new class:

https://github.com/LeaVerou/color.js/blob/e939c7cc70b473a9bfe07fe9d8c4c1c46ef3f754/src/clone.js#L2-L6

@LeaVerou
Copy link
Member

Thanks!

@MysteryBlokHed
Copy link
Member Author

Note: This PR won’t be relevant if #291 is merged

@MysteryBlokHed MysteryBlokHed deleted the types/fix-clone-signature branch April 12, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeaVerou LeaVerou LeaVerou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect type definition for clone()
2 participants
@MysteryBlokHed @LeaVerou