Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skip-on-error option to spanner:warmup command #70

Merged
merged 4 commits into from
Jan 31, 2023
Merged

feat: add skip-on-error option to spanner:warmup command #70

merged 4 commits into from
Jan 31, 2023

Conversation

taka-oyama
Copy link
Collaborator

No description provided.

@taka-oyama taka-oyama added the enhancement New feature or request label Jan 30, 2023
@taka-oyama taka-oyama requested review from dkkoma and halnique January 30, 2023 08:30
@taka-oyama taka-oyama self-assigned this Jan 30, 2023
tyabu12
tyabu12 suggested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@tyabu12 tyabu12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a description of this change to CHANGELOG.md?

@taka-oyama
Copy link
Collaborator Author

Could you add a description of this change to CHANGELOG.md?

Thanks for the reminder. CHANGELOG has been added.

@taka-oyama taka-oyama requested review from tyabu12 and halnique and removed request for tyabu12 January 30, 2023 09:35
@taka-oyama taka-oyama changed the base branch from master to 4.x January 30, 2023 12:08
@taka-oyama taka-oyama requested a review from tyabu12 January 31, 2023 01:07
@taka-oyama taka-oyama merged commit 4ac644f into 4.x Jan 31, 2023
@taka-oyama taka-oyama deleted the feature/warmup-skip-on-error branch January 31, 2023 02:11
taka-oyama added a commit that referenced this pull request Jan 31, 2023
@taka-oyama
feat: add skip-on-error option to spanner:warmup command (#70)
6f6d865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halnique halnique halnique approved these changes

@dkkoma dkkoma Awaiting requested review from dkkoma

@tyabu12 tyabu12 Awaiting requested review from tyabu12

Assignees

@taka-oyama taka-oyama

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taka-oyama @tyabu12 @halnique