Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix formatting #238

Merged
merged 5 commits into from
Nov 8, 2024
Merged

chore: fix formatting #238

merged 5 commits into from
Nov 8, 2024

Conversation

taka-oyama
Copy link
Collaborator

@taka-oyama taka-oyama commented Nov 6, 2024

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Improved error handling in the executeBatchDml method to provide more detailed error messages.
    • Enhanced handling of array values in the escape method to enforce stricter input rules.
  • New Features

    • Added explicit return types to the table and query methods for better type safety.
  • Style

    • Numerous formatting improvements across various classes and tests for better readability and consistency, including adjustments to spacing in function definitions and method calls.
  • Tests

    • Enhanced test assertions and formatting for improved clarity and reliability in database operation tests.
    • Standardized spacing and formatting in test methods to improve code readability.

@taka-oyama taka-oyama requested a review from a team November 6, 2024 05:56
@taka-oyama taka-oyama self-assigned this Nov 6, 2024
Copy link

coderabbitai bot commented Nov 6, 2024

Walkthrough

This pull request introduces various formatting changes across multiple files, primarily focusing on improving code readability and consistency. Changes include adjustments to spacing around operators, method signatures, and PHPDoc annotations, as well as the addition of trailing commas in method calls. Overall, the modifications are cosmetic and do not affect the logic or functionality of the code.

Changes

File Change Summary
src/Concerns/ManagesDataDefinitions.php Minor formatting change in waitForOperation method, adjusted spacing around json_encode.
src/Concerns/ManagesMutations.php Formatting change in createDeleteMutationKeySet method, improved spacing in exception message.
src/Concerns/ManagesSessionPool.php Formatting change in warmupSessionPool method, added space after if keyword.
src/Concerns/ManagesTransactions.php Formatting changes in PHPDoc comments and method calls, added trailing commas in method calls.
src/Concerns/MarksAsNotSupported.php Formatting adjustment in markAsNotSupported method's exception message concatenation.
src/Concerns/SharedGrammarCalls.php Formatting change in wrapValue method's return statement, adjusted string concatenation.
src/Connection.php Return type changes for table and query methods, formatting adjustments in executeBatchDml.
src/Console/SessionsCommand.php Formatting changes in makeSessionData method, improved spacing in anonymous functions.
src/Eloquent/Model.php Parameter annotations reformatted in resolveChildRouteBindingQuery method.
src/Query/ArrayValue.php Added trailing comma in constructor parameter list.
src/Query/Builder.php Minor formatting changes in updateOrInsert, upsert, and runSelect methods.
src/Query/Concerns/UsesPartitionedDml.php Added trailing commas in method calls for prepareBindingsForUpdate and prepareBindingsForDelete.
src/Query/Grammar.php Formatting changes in method return statements and error handling messages.
src/Query/Parameterizer.php Changed else if to elseif for consistency in conditional statements.
src/Query/Processor.php Changed else if to elseif in processSelect method.
src/Schema/Blueprint.php Adjusted parameter annotations for consistency and added trailing commas in method calls.
src/Schema/Builder.php Formatting improvements in getTables, dropIndexIfExist, and dropAllTables methods.
src/Schema/Grammar.php Adjusted PHPDoc comments and added commas in method calls for consistency.
tests/Concerns/ManagesDataDefinitionsTest.php Formatting changes in lambda function definitions for consistency.
tests/ConnectionTest.php Formatting improvements in closures and SQL statements.
tests/Eloquent/ModelTest.php Adjusted spacing around concatenation operators in multiple methods.
tests/Query/BuilderTest.php Minor whitespace changes and assertion adjustments in various test methods.
tests/Query/ParameterizerTest.php Reformatted $bindings variable for improved readability.
tests/Query/SpannerArrayTest.php Added spaces around + operator in testSearchInArray method.
tests/Schema/BlueprintTest.php Updated SQL assertions for correct formatting in multiple test methods.
tests/Schema/BuilderTestLast.php Standardized spacing in arrow function declarations and comments.
tests/SpannerServiceProviderTest.php Removed space between fn and parentheses in test_change_cache_path method.
tests/TestCase.php Various formatting adjustments for consistency in TestCase class.
tests/TransactionTest.php Standardized formatting in use statements and exception handling syntax.
tests/bootstrap.php Minor formatting adjustments in autoload requirement and shutdown function.

Possibly related PRs

  • feat: add change stream support #230: This PR modifies the waitForOperation method in the ManagesDataDefinitions trait, while the retrieved PR adds change stream support in the Blueprint class, indicating a potential relationship in handling data definitions and operations.

Suggested reviewers

  • Uyan712

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f446b8b and 535d88b.

📒 Files selected for processing (1)
  • tests/TestCase.php (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/TestCase.php

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@taka-oyama taka-oyama mentioned this pull request Nov 6, 2024
15 tasks
@taka-oyama taka-oyama force-pushed the chore/fix-formatting branch from c5da8f2 to 091d691 Compare November 6, 2024 10:57
Copy link
Contributor

@halnique halnique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taka-oyama taka-oyama merged commit b9d3cb8 into master Nov 8, 2024
1 check passed
@taka-oyama taka-oyama deleted the chore/fix-formatting branch November 8, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants