-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for whereNotInUnnest #225
Conversation
WalkthroughThe recent update to version 8.3.0 introduces significant enhancements to the Query Builder, including a new method Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- CHANGELOG.md (1 hunks)
- src/Query/Builder.php (1 hunks)
- src/Query/Grammar.php (2 hunks)
- tests/Query/BuilderTest.php (1 hunks)
- tests/Query/UnnestTest.php (1 hunks)
Files skipped from review due to trivial changes (1)
- tests/Query/BuilderTest.php
Additional comments not posted (5)
tests/Query/UnnestTest.php (1)
77-99
: LGTM! The new test method is well-structured.The
test_whereNotInUnnest
method is well-written and follows the existing patterns in the class. It effectively validates the functionality of thewhereNotInUnnest
method.src/Query/Grammar.php (1)
Line range hint
124-141
:
LGTM! The updates improve readability and robustness.The changes to the
whereInUnnest
method enhance the clarity of the expected input structure and improve the control flow by clearly separating the conditions.src/Query/Builder.php (2)
154-167
: LGTM! The updates enhance functionality.The addition of the
bool $not
parameter to thewhereInUnnest
method expands its functionality to handle both inclusion and exclusion scenarios. The internal logic updates are appropriate and maintain consistency.
168-177
: LGTM! The new method is a valuable addition.The
whereNotInUnnest
method is a straightforward and valuable addition that leverages the existingwhereInUnnest
method to handle exclusion scenarios, enhancing the query builder's capabilities.CHANGELOG.md (1)
1-3
: Changelog entry looks good!The entry accurately describes the addition of the
whereNotInUnnest
method.
Thank you for the review |
Summary by CodeRabbit
New Features
whereNotInUnnest
method to enhance query filtering capabilities.whereInUnnest
method to support both inclusion and exclusion scenarios.Bug Fixes
whereInUnnest
method's parameter handling.Chores
Tests
whereNotInUnnest
method to ensure correct functionality.