Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropAll() return immediately if no tables found #193

Merged
merged 9 commits into from
Mar 5, 2024
+28 −0
Merged

dropAll() return immediately if no tables found #193

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
48ba8bc
Update Builder.php - dropAll() return immediately if no tables found
matthewjumpsoffbuildings Mar 4, 2024
241564f
test dropAllTables with empty table list
matthewjumpsoffbuildings Mar 4, 2024
1d62b01
Update BuilderTestLast.php
matthewjumpsoffbuildings Mar 5, 2024
a1647ac
Update tests/Schema/BuilderTestLast.php
taka-oyama Mar 5, 2024
f40576d
Update tests/Schema/BuilderTestLast.php
taka-oyama Mar 5, 2024
b21e6fe
Merge branch 'colopl:master' into drop-no-tables
matthewjumpsoffbuildings Mar 5, 2024
fbaf1c8
Update CHANGELOG.md
matthewjumpsoffbuildings Mar 5, 2024
22e1b5b
Update CHANGELOG.md
matthewjumpsoffbuildings Mar 5, 2024
2ccaac9
Update CHANGELOG.md
taka-oyama Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Schema/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@ public function dropAllTables()
/** @var Connection $connection */
$connection = $this->connection;
$tables = $this->getTables();

if(count($tables) === 0) {
return;
}

$sortedTables = [];

// add parents counter
Expand Down
18 changes: 18 additions & 0 deletions tests/Schema/BuilderTestLast.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,4 +307,22 @@ public function test_dropAllTables(): void
$tables = $sb->getTables();
$this->assertEmpty($tables);
}

public function test_dropAllTables_when_no_tables_exist(): void
{
$conn = $this->getDefaultConnection();
$sb = $conn->getSchemaBuilder();

// All tables must be dropped before hand to ensure that this test will cover the "early return" case
// for when there are no tables.
$sb->dropAllTables();
taka-oyama marked this conversation as resolved.
Show resolved Hide resolved

$tables = $sb->getTables();
$this->assertEmpty($tables);

$sb->dropAllTables();

$tables = $sb->getTables();
$this->assertEmpty($tables);
}
}
Loading