Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: partitionedDml can be tested in emulator now #187

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

taka-oyama
Copy link
Collaborator

No description provided.

@taka-oyama taka-oyama added the chore Basic cleanup label Feb 21, 2024
@taka-oyama taka-oyama added this to the 7.0 milestone Feb 21, 2024
@taka-oyama taka-oyama self-assigned this Feb 21, 2024
$conn->table($tableName)->insert($insertValues);
});

// normal DML should throw error since its over 20000 rows
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DML mutation limit has been raised to 80k and PHP now runs of out memory before it reaches that point so removing test to check the mutation limit.

Copy link
Contributor

@tyabu12 tyabu12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taka-oyama taka-oyama merged commit 8bf74d5 into master Feb 22, 2024
1 check failed
@taka-oyama taka-oyama deleted the chore/modernize-test branch February 22, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Basic cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants