Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow spanner_emulator.disable_query_null_filtered_index_check to be set #180

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

taka-oyama
Copy link
Collaborator

An error is thrown when the following condition is met.

  • Spanner Emulator is used
  • index is defined as NULL_FILTERED
  • FORCE_INDEX statement hint is set on the query

This allows it to be bypassed by calling Builder::disableEmulatorNullFilterIndexCheck().

@taka-oyama taka-oyama added the enhancement New feature or request label Feb 15, 2024
@taka-oyama taka-oyama added this to the 7.0 milestone Feb 15, 2024
@taka-oyama taka-oyama self-assigned this Feb 15, 2024
src/Query/Builder.php Outdated Show resolved Hide resolved
src/Query/Builder.php Outdated Show resolved Hide resolved
src/Query/Builder.php Outdated Show resolved Hide resolved
Co-authored-by: Kazuki Yamada <[email protected]>
@taka-oyama taka-oyama requested a review from yamadashy February 16, 2024 01:57
Copy link
Contributor

@tyabu12 tyabu12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taka-oyama taka-oyama merged commit 09a3115 into master Feb 16, 2024
1 check passed
@taka-oyama taka-oyama deleted the feature/emulator-null-filter-check branch February 16, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants