feat: add support for Schema::increments #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taka-oyama
requested review from
dkkoma,
kt81,
zeriyoshi,
halnique,
Uyan712 and
t-matsuno-777
taka-oyama
force-pushed
the
feature/uuid-support
branch
from
fdb5a0a to
8b54515
Compare
Co-authored-by: Tomohito YABU <[email protected]>
taka-oyama
force-pushed
the
feature/increments-support
branch
from
7b7d86c to
4a5a8cf
Compare
tyabu12
suggested changes
Feb 19, 2024
src/Schema/ColumnDefinition.php
Outdated
| use Illuminate\Database\Query\Expression; | ||
| use Illuminate\Database\Schema\ColumnDefinition as BaseColumnDefinition; | ||
|
|
||
| class ColumnDefinition extends BaseColumnDefinition |
There was a problem hiding this comment.
Since UuidColumnDefinition is used, it does not seem necessary to add this class.
tyabu12
reviewed
Feb 19, 2024
taka-oyama
commented
Feb 19, 2024
taka-oyama
commented
Feb 19, 2024
|
Thanks for reviewing! @tyabu12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow migrations, jobs and other database related features to work properly.
#174 needs to be merged first.
Closes #157