Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: optimize build local container image #116

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

zeriyoshi
Copy link
Contributor

@zeriyoshi zeriyoshi commented Jun 20, 2023

gRPC is a very large extension and takes a long time to compile. Use parallel compilation to speed up the setup of local environment.

Composer also changed because it is faster to retrieve from a pre-built image.

Checklist

- [ ] CHANGELOG

@zeriyoshi zeriyoshi requested a review from taka-oyama June 20, 2023 09:32
@zeriyoshi zeriyoshi self-assigned this Jun 20, 2023
@zeriyoshi zeriyoshi added the chore Basic cleanup label Jun 20, 2023
@taka-oyama
Copy link
Collaborator

Please add comments to explain what its doing.

@zeriyoshi zeriyoshi requested a review from t-matsuno-777 June 21, 2023 01:11
@zeriyoshi
Copy link
Contributor Author

@taka-oyama
fixed it!

Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Takayasu Oyama <[email protected]>
@zeriyoshi zeriyoshi requested a review from taka-oyama June 21, 2023 01:27
@taka-oyama taka-oyama requested review from dkkoma and halnique June 21, 2023 02:28
@taka-oyama taka-oyama merged commit 13ce76d into colopl:master Jun 21, 2023
taka-oyama added a commit that referenced this pull request Jul 18, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Jul 19, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Aug 14, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Aug 16, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Aug 17, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Aug 18, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Aug 18, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Aug 22, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Aug 22, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
taka-oyama added a commit that referenced this pull request Nov 17, 2023
* Dockerfile: use composer binary from official container image

* Dockerfile: optimize pecl extension build

* [skip ci] Dockerfile: add document

* [skip ci] Update Dockerfile

Co-authored-by: Takayasu Oyama <[email protected]>

---------

Co-authored-by: Takayasu Oyama <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Basic cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants