Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insertOrUpdateUsingMutation #109

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Add insertOrUpdateUsingMutation #109

merged 1 commit into from
Jun 13, 2023

Conversation

Xfaider48
Copy link
Contributor

@Xfaider48 Xfaider48 commented Jun 1, 2023 •
edited
Loading

  • Add insertOrUpdateUsingMutation
  • change ManagesMutations private methods to protected (I faced with a problem of reusing ManagesMutations methods when I tried to add insertOrUpdateUsingMutation locally in my project)

Checklist

  • CHANGELOG

Reference

@alexeylivadnyi
Copy link

Will be usefull, I also faced this

@taka-oyama taka-oyama self-assigned this Jun 2, 2023
@taka-oyama taka-oyama added the enhancement New feature or request label Jun 2, 2023
@taka-oyama
Copy link
Collaborator

Hi, thanks for the PR.

This looks good.
Could you please add a change log and rebase on master (I added a CI trigger for pull requests).

@r4m-alexd
feat: Add insertOrUpdateUsingMutation
3e6dee3 
+ change ManagesMutations private methods to protected.
@Xfaider48
Copy link
Contributor Author

@taka-oyama Done

@taka-oyama taka-oyama merged commit 814f62e into colopl:master Jun 13, 2023
@taka-oyama
Copy link
Collaborator

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taka-oyama taka-oyama taka-oyama left review comments

Assignees

@taka-oyama taka-oyama

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xfaider48 @alexeylivadnyi @taka-oyama @r4m-alexd