fix: throw exception if no primary key is defined. (#58)

Co-authored-by: Taka Oyama <[email protected]>
# Conflicts:
#	tests/Schema/BlueprintTest.php

CHANGELOG.md

@@ -12,6 +12,9 @@ Changed
 Fixed
 - SessionPool was not cleared if php terminated immediately after calling `CacheSessionPool::clear`.
 
+Changed
+- Checks that primary key is defined in schema and throws an exception if not defined.
+
 # v4.3.0
 
 Added

src/Schema/Grammar.php

@@ -302,7 +302,7 @@ protected function addPrimaryKeys(Blueprint $blueprint)
         if (! is_null($primary = $this->getCommandByName($blueprint, 'primary'))) {
             return "primary key ({$this->columnize($primary->columns)})";
         }
-        return '';
+        throw new LogicException('Cloud Spanner require a primary key!');
     }
 
     /**

tests/Schema/BlueprintTest.php

@@ -150,6 +150,18 @@ public function testDropIndex(): void
         );
     }
 
+    public function test_no_primaryKey(): void
+    {
+        $this->expectException(LogicException::class);
+        $this->expectExceptionMessage('Cloud Spanner require a primary key!');
+
+        $blueprint = new Blueprint('test', function (Blueprint $table) {
+            $table->create();
+            $table->uuid('id');
+        });
+        $blueprint->toSql($this->getDefaultConnection(), new Grammar());
+    }
+
     public function testCompositePrimaryKey(): void
     {
         $conn = $this->getDefaultConnection();