Replace kadmin.py with python-kadmin #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.kadmin = kadmin.KAdmin(config["krb5"]["aprinc"], | ||
| config["krb5"]["atab"]) | ||
| self.kadm = kadmin.init_with_keytab(config["krb5"]["aprinc"], | ||
| config["krb5"]["atab"]) |
There was a problem hiding this comment.
This should be keytab, and should default if unset to the system keytab.
There was a problem hiding this comment.
What do you mean by "this should be keytab"?
There was a problem hiding this comment.
s/atab/keytab/
But really it shouldn't be set at all. Its pretty standard to just use the system keytab for applications that are binding with machine level access.
| @@ -113,7 +113,7 @@ def connectLDAP(self): | |||
| return conn | |||
|
|
|||
| def chPassword(self, username, password): | |||
| return self.kadmin.chPassword(username, password) | |||
| return self.kadm.get_princ(username).change_password(password) | |||
There was a problem hiding this comment.
This should probably be split into 2 calls with a try/except. If the get_princ() call fails you'll be trying to call a method on None.
|
Merged. |
|
Reopened due to issues with kadmin. Will retest and reconsider at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.