Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ActiveSupport 7.0.3 Compatibility #1169

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix: ActiveSupport 7.0.3 Compatibility #1169

merged 1 commit into from
Sep 28, 2022

Conversation

arielvalentin
Copy link

Fixes #1168

@arielvalentin arielvalentin marked this pull request as ready for review May 10, 2022 00:12
@arielvalentin
Copy link
Author

👋🏼 @willnet @albus522 I see you are the most recent contributors to the project and was hoping to get some feedback from you all re: this PR.

https://github.com/collectiveidea/delayed_job/graphs/contributors?from=2021-05-29&to=2022-06-04&type=c

@arielvalentin
Copy link
Author

Ping @willnet @albus522 🙏🏼

@arielvalentin
Copy link
Author

Ping @willnet @albus522

@willnet
Copy link

willnet commented Aug 30, 2022

As I commented #1168 (comment) LGTM, but I'm not a committer so I can't merge this PR.

@arielvalentin
Copy link
Author

my apologies @willnet

Is @albus522 still a maintainer?

@albus522 albus522 merged commit 0ebfebd into collectiveidea:master Sep 28, 2022
@arielvalentin arielvalentin mentioned this pull request Dec 28, 2022
Closed
@arielvalentin arielvalentin deleted the as-7.0.3 branch October 9, 2023 02:30
@arielvalentin arielvalentin mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error since ActiveSupport 7.0.3: undefined method silence_warnings' for Delayed::Worker:Class (NoMethodError)`
3 participants
@arielvalentin @willnet @albus522