Use ActiveSupport.on_load to inject modules #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a load order issue where routes were not loaded in tests due to ActionView being referenced here before it was fully loaded. The rails documentation seems to recommends using these hooks, so I have changed active_record to use it as well instead of requiring active_record.
|
@danielmorrison sorry for the ping, but is there anything I can do to move this forward? This issue prevents me from upgrading solidus to rails 5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a load order issue where routes were not loaded in tests due to ActionView being referenced here before it was fully loaded.
The rails documentation seems to recommends using these hooks, so I have changed the injection into
ActiveRecord::Baseto use it as well instead of requiring active_record.See also rails/rails-controller-testing#24 especially this comment for additional details.