Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set video captions when using VideoJS media viewer #21

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Set video captions when using VideoJS media viewer #21

merged 1 commit into from
Oct 27, 2020

Conversation

solodolo
Copy link

I noticed that captions are not being set in the $pa_options sent to Video.php when using the VideoJS media viewer. This change adds them in a way similar to how TileViewer does it, so that VTT and SRT caption files are correctly displayed by video.js.

@collectiveaccess collectiveaccess merged commit 84e6703 into collectiveaccess:develop Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants