Refactored Rep Thumbnail Clicks #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes problems with thumbnail and slide ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
The previous implementation assumed slides could be indexed using the thumbnail sequence, which does not work because thumbnails and slides are not in the same order unless the primary representation happens to be first.
This PR refactors the function
setItemto assume the input is a thumbnail sequence number, not the slide array index and not the representation ID. This function grabs the thumbnail's representation ID and scans the slide list to find the corresponding slide index.Added function
setByIndexwhich assumes the input is the targeted slide array index. This function extracts the representation ID from the slide list and uses it to find the element ID of a corresponding thumbnail.