-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "examples" directory for example frontends #73
Conversation
@MAX-786 You need to remove the |
One other thing I added in #74 that should also be added here are some simple Makefile commands and an npm script to start the admin UI with the default URL set to the URL of the example frontend and a command to start the example frontend without having to know anything about it. E.g: ## Examples
.PHONY: example-astro-admin
example-astro-admin:
RAZZLE_DEFAULT_IFRAME_URL=http://localhost:4321 pnpm start
.PHONY: example-astro-frontend
example-astro-frontend: ## Starts Volto, allowing reloading of the add-on during development
pnpm example:astro Then in package.json: "example:astro": "pnpm --filter hydra-astro run dev" |
@JeffersonBledsoe Updated as per requested and also updated the readme for the instructions! |
@MAX-786 I notice the hydra.js is checked intot he example which is probably shouldn't be right? |
Oh thanks!! I'll remove it from the example folder, Just a little thing, what might be the better way to do it, a separate PR or just restore this branch add that commit and merge again? |
updated example frontend readme for instructions.