Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom merge strategy for changelog #208

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

untitaker
Copy link
Contributor

This causes old PRs to add the changelog entry to already released
versions. It happened to me while rebasing #207

This causes old PRs to add the changelog entry to already released
versions. It happened to me while rebasing collective#207
@untitaker
Copy link
Contributor Author

perhaps cc @mauritsvanrees who was the original author of this commit

@mauritsvanrees
Copy link
Member

The reason for the union merge, is to avoid this situation:

  • PR 1 has a changelog entry
  • PR 2 has a changelog entry
  • PR 1 gets merged
  • You look at PR 2 and see that there is a merge conflict. From looking at github you have no idea if this is a simple conflict in the changelog, which you could quickly fix while merging manually, or a nasty conflict elsewhere that may take far longer. So you ignore the pull request for now, or ask the author to rebase, and everything takes longer.

That's the theory. And usually it seems to go fine.

But in practice, I have seen problems like you mention. Or the changelog entry will end up under the correct header, but without enough white space, or with problems that break the ReStructuredText rendering on PyPI. So I have also become less enthused about this.

So let's merge this and see what the effects are.
Later we can maybe do this for other packages as well.

@mauritsvanrees mauritsvanrees merged commit 74ef4c1 into collective:master Jan 25, 2017
@untitaker
Copy link
Contributor Author

untitaker commented Jan 25, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants