Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect id #215

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix incorrect id #215

merged 1 commit into from
May 21, 2024

Conversation

mikejritter
Copy link
Contributor

@mikejritter mikejritter commented May 20, 2024

What does this do?

  • Fixes the condition group message id

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1424

This is an inconsistency in the field config which was noticed by Kristina.

How should this be tested? Do these changes have associated tests?
Non-functional change so this isn't tested

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter ran npm run lint and npm run test as a sanity check

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (6f92c81) to head (d5635a7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files         562      562           
  Lines       12542    12542           
  Branches     2585     2599   +14     
=======================================
  Hits        12317    12317           
  Misses        222      222           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 21fa7f4 into collectionspace:master May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants