Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to landing page #208

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Adds 'Welcome' message to the welcome/login page.

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1306

This adds additional information to the page title about the purpose of the page. I was stuck between deciding on Welcome and Log in (similar to the ServiceLoginPage), and ultimately settled on Weclome. Updating the message isn't a problem if it needs to be changed.

One odd thing is that the description for both the LoginPage and the ServiceLoginPlage have the same description. It might be worthwhile to simply rename to the LoginPage since it now directs the user to the login form.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • Navigate to localhost:8080
    • Note: You might be automatically redirected to the service login page, in which case you can login and logout to get back to the welcome message
  • See that the title of the page includes Welcome

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (a2a8403) to head (3b6de8d).

❗ Current head 3b6de8d differs from pull request most recent head dd8660d. Consider uploading reports for the commit dd8660d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files         555      555           
  Lines       12505    12508    +3     
  Branches     2597     2586   -11     
=======================================
+ Hits        12281    12284    +3     
  Misses        221      221           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejritter mikejritter changed the title Add title to welcome page Add title to landing page Apr 4, 2024
Copy link
Member

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikejritter I think you're right about renaming LoginPage. How about making it WelcomePage, since that's what it really is now?

@ray-lee
Copy link
Member

ray-lee commented Apr 23, 2024

@mikejritter We could have WelcomePage be at /welcome, change / to redirect to /welome, and change /login to redirect to the services login page.

@mikejritter
Copy link
Contributor Author

@ray-lee Changes are now made for renaming LoginPage to WelcomePage and updating the route for the page to /welcome. Master ended up being merged twice and the displayed changes were out of sync, so I rebased and did a force push to clean up the PR.

I was having some trouble testing that the initial request on / will redirect to /welcome as I automatically get redirected to cspace-services/login. I'm not sure if that's a webpack thing or what because I noticed core.dev doesn't have that behavior.

Copy link
Member

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Never mind about redirecting / to /welcome. I forgot that / is set to redirect to /search, which requires auth, so it bounces you to the services login page. That can stay the same.

@ray-lee ray-lee merged commit a668883 into collectionspace:master Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants