Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease multiline height for various fields #205

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Set height to 23px for note fields in annotation and status groups

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1284
Jira: https://collectionspace.atlassian.net/browse/DRYD-1285

This is just a small styling tweak requested from feedback. I saw 23px defined in the dimensions for cspace-input and went with that for the size.

How should this be tested? Do these changes have associated tests?

  • Run the devserver
  • View the note field in the following procedures
    • acquisition - approval group
    • collectionobject - annotation group
    • intake - approval group
    • loan in - loan status group
    • loan out - loan status group
    • object exist - deaccession approval group
    • uoc - authorization group

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (dedc1ee) to head (5c3fe8a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         555      555           
  Lines       10899    10899           
  Branches     1196     1196           
=======================================
  Hits        10403    10403           
  Misses        147      147           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 5540a0b into collectionspace:master Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants